describe(ꞌUser.managerꞌ) - Code Metrics - Inspection of "Merge pull request #50 from AdFabConnect/issue-46" - AdFabConnect/abejs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 34f5de...9cf608 )

by greg

created 2016-11-29 14:39 UTC

describe(ꞌUser.managerꞌ) A

↳ Parent: test/users/manager.js

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	72
rs	9.102
c	1
b	0
f	0

5 Functions

Rating	Name	Size	Complexity
A	��)	13	1
A	��)	18	1
A	��)	13	1
A	��)	14	1
A	��)	8	1

How to fix Long Method

var chai = require('chai');
var sinonChai = require('sinon-chai')
var expect = chai.expect
chai.use(sinonChai)
var sinon = require('sinon');
var fs = require('fs-extra');
var path = require('path');

var coreUtils = require('../../src/cli').coreUtils
var config = require('../../src/cli').config
config.set({root: path.join(process.cwd(), 'test', 'fixtures')})

var User = require('../../src/cli').User;

describe('User.manager', function() {
  before( function() {
    config.users.enable = true
    this.fixture = {
      htmlIsAuthorized: fs.readFileSync(path.join(process.cwd(), 'test', 'fixtures', 'templates', 'isAuthorized.html'), 'utf8'),
      htmlIsAuthorizedTrue: fs.readFileSync(path.join(process.cwd(), 'test', 'fixtures', 'templates', 'isAuthorizedTrue.html'), 'utf8'),
      users: JSON.parse(fs.readFileSync(path.join(process.cwd(), 'test', 'fixtures', 'users', 'users.json'), 'utf8'))
    }
  });

  it('User.manager.instance.get', function(){
    // stub
    var sinonInstance = sinon.sandbox.create();
    var stubRead = sinonInstance.stub(User.manager.instance, 'read');
    stubRead.returns(JSON.parse(JSON.stringify(this.fixture.users)))

    // test
    var res = User.manager.instance.get()
    chai.expect(res.length).to.be.above(0)

    // unstub
    User.manager.instance.read.restore()
  })

  it('User.manager.instance.save', function(){
    // stub
    var sinonInstance = sinon.sandbox.create();
    var stubFs = sinonInstance.stub(fs, 'writeJsonSync');
    stubFs.returns(null)

    // test
    var res = User.manager.instance.save()


    // unstub
    sinon.assert.calledOnce(fs.writeJsonSync)
    fs.writeJsonSync.restore()
  })

  it('User.manager.instance.read', function(){
    // stub
    var sinonInstance = sinon.sandbox.create();
    var stubFs = sinonInstance.stub(fs, 'readFileSync');
    stubFs.returns(JSON.stringify(this.fixture.users))
    var stubExist = sinonInstance.stub(coreUtils.file, 'exist');
    stubExist.returns(true)

    // test
    var res = User.manager.instance.read()
    chai.expect(res).to.not.be.null


    // unstub
    sinon.assert.calledOnce(fs.readFileSync)
    fs.readFileSync.restore()
    sinon.assert.calledOnce(coreUtils.file.exist)
    coreUtils.file.exist.restore()
  })

  it('User.manager.instance.update', function(){
    // stub
    var sinonInstance = sinon.sandbox.create();
    var stubSave = sinonInstance.stub(User.manager.instance, 'save');
    stubSave.returns(JSON.parse(JSON.stringify(this.fixture.users)))

    // test
    var res = User.manager.instance.update()
    chai.expect(res).to.be.equal(true)

    // unstub
    sinon.assert.calledOnce(User.manager.instance.save)
    User.manager.instance.save.restore()
  })
});

1			var chai = require('chai');
2			var sinonChai = require('sinon-chai')
3			var expect = chai.expect
4			chai.use(sinonChai)
5			var sinon = require('sinon');
6			var fs = require('fs-extra');
7			var path = require('path');
8
9			var coreUtils = require('../../src/cli').coreUtils
10			var config = require('../../src/cli').config
11			config.set({root: path.join(process.cwd(), 'test', 'fixtures')})
12
13			var User = require('../../src/cli').User;
14
15			describe('User.manager', function() {
16			before( function() {
17			config.users.enable = true
18			this.fixture = {
19			htmlIsAuthorized: fs.readFileSync(path.join(process.cwd(), 'test', 'fixtures', 'templates', 'isAuthorized.html'), 'utf8'),
20			htmlIsAuthorizedTrue: fs.readFileSync(path.join(process.cwd(), 'test', 'fixtures', 'templates', 'isAuthorizedTrue.html'), 'utf8'),
21			users: JSON.parse(fs.readFileSync(path.join(process.cwd(), 'test', 'fixtures', 'users', 'users.json'), 'utf8'))
22			}
23			});
24
25			it('User.manager.instance.get', function(){
26			// stub
27			var sinonInstance = sinon.sandbox.create();
28			var stubRead = sinonInstance.stub(User.manager.instance, 'read');
29			stubRead.returns(JSON.parse(JSON.stringify(this.fixture.users)))
30
31			// test
32			var res = User.manager.instance.get()
33			chai.expect(res.length).to.be.above(0)
34
35			// unstub
36			User.manager.instance.read.restore()
37			})
38
39			it('User.manager.instance.save', function(){
40			// stub
41			var sinonInstance = sinon.sandbox.create();
42			var stubFs = sinonInstance.stub(fs, 'writeJsonSync');
43			stubFs.returns(null)
44
45			// test
46			var res = User.manager.instance.save()
			0 ignored issues – show Unused Code introduced 2016-11-29 14:01 UTC by Report Bug Copy Issue Report The variable `res` seems to be never used. Consider removing it. Loading history...
47
48			// unstub
49			sinon.assert.calledOnce(fs.writeJsonSync)
50			fs.writeJsonSync.restore()
51			})
52
53			it('User.manager.instance.read', function(){
54			// stub
55			var sinonInstance = sinon.sandbox.create();
56			var stubFs = sinonInstance.stub(fs, 'readFileSync');
57			stubFs.returns(JSON.stringify(this.fixture.users))
58			var stubExist = sinonInstance.stub(coreUtils.file, 'exist');
59			stubExist.returns(true)
60
61			// test
62			var res = User.manager.instance.read()
63			chai.expect(res).to.not.be.null
			0 ignored issues – show introduced 2016-11-29 14:01 UTC by Report Bug Copy Issue Report The result of the property access to `chai.expect(res).to.not.be.null` is not used. Loading history...
64
65			// unstub
66			sinon.assert.calledOnce(fs.readFileSync)
67			fs.readFileSync.restore()
68			sinon.assert.calledOnce(coreUtils.file.exist)
69			coreUtils.file.exist.restore()
70			})
71
72			it('User.manager.instance.update', function(){
73			// stub
74			var sinonInstance = sinon.sandbox.create();
75			var stubSave = sinonInstance.stub(User.manager.instance, 'save');
76			stubSave.returns(JSON.parse(JSON.stringify(this.fixture.users)))
77
78			// test
79			var res = User.manager.instance.update()
80			chai.expect(res).to.be.equal(true)
81
82			// unstub
83			sinon.assert.calledOnce(User.manager.instance.save)
84			User.manager.instance.save.restore()
85			})
86			});

AdFabConnect / abejs

Push — master ( 34f5de...9cf608 )

describe(ꞌUser.managerꞌ) A

Complexity

Size

Duplication

Importance

5 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like